Skip to content

sysfs: tolerate EFBIG when reading cpufreq stats/trans_table #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinpark1217 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sysfs: tolerate EFBIG when reading cpufreq stats/trans_table #852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sysfs/system_cpu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
package sysfs

import (
"errors"
"fmt"
"os"
"path/filepath"
"strconv"
"strings"
"syscall"

"golang.org/x/sync/errgroup"

Expand Down Expand Up @@ -350,10 +352,14 @@ func parseCpufreqCpuinfo(cpuPath string) (*SystemCPUCpufreqStats, error) {
}

// "trans_table" contains information about all the CPU frequency transitions.
// The kernel disables its export with EFBIG when the table exceeds PAGE_SIZE
// ("cpufreq transition table exceeds PAGE_SIZE. Disabling"), which happens on
// CPUs with many frequency states (e.g. NVIDIA Jetson / Tegra) — treat that
// like an absent file instead of failing the whole cpufreq read.
var cpuinfoTransitionTable *[][]uint64
cpuinfoTransitionTableString, err := util.ReadFileNoStat(filepath.Join(cpuPath, "stats", "trans_table"))
if err != nil {
if !os.IsNotExist(err) && !os.IsPermission(err) {
if !os.IsNotExist(err) && !os.IsPermission(err) && !errors.Is(err, syscall.EFBIG) {
return &SystemCPUCpufreqStats{}, err
}
} else {
Expand Down