Skip to content

fix: handle 'delayed' state in sync_completed parsing #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mehrdadbn9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle 'delayed' state in sync_completed parsing #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sysfs/mdraid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func (fs FS) Mdraids() ([]Mdraid, error) {
}

if val, err := util.SysReadFile(filepath.Join(path, "sync_completed")); err == nil {
if val != "none" {

@dswarbrick dswarbrick Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though "none" and "delayed" are currently the only two special cases (as of kernel v6.19.10), I wonder if this would be more robust if we performed a regex match, or flipped the logic around the fmt.Sscanf so that it would handle future special cases that don't match the %d / %d format.

if val != "none" && val != "delayed" {
var a, b uint64

// File contains two values representing the fraction of number of completed
Expand Down
23 changes: 23 additions & 0 deletions sysfs/mdraid_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,26 @@ func TestMdraidStats(t *testing.T) {
t.Fatalf("unexpected Mdraid (-want +got):\n%s", diff)
}
}
func TestMdraidDelayedSyncCompleted(t *testing.T) {
fs, err := NewFS("testdata/fixtures/sys/issue770")
if err != nil {
t.Fatal(err)
}

mdraids, err := fs.Mdraids()
if err != nil {
t.Fatal(err)
}

if len(mdraids) != 1 {
t.Fatalf("expected 1 mdraid, got %d", len(mdraids))
}

md := mdraids[0]
if md.SyncCompleted != 0 {
t.Fatalf("expected SyncCompleted=0 for 'delayed' state, got %f", md.SyncCompleted)
}
if md.SyncAction != "resync" {
t.Fatalf("expected SyncAction='resync', got '%s'", md.SyncAction)
}
}
89 changes: 89 additions & 0 deletions testdata/fixtures.ttar
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19494,6 +19494,95 @@ Lines: 1
extent_alloc 2 0 0 0
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/issue770
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/issue770/block
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/issue770/block/md127
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/issue770/block/md127/md
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/array_state
Lines: 1
clean
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/chunk_size
Lines: 1
524288
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/degraded
Lines: 1
0
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/issue770/block/md127/md/dev-sdaa
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/dev-sdaa/state
Lines: 1
spare
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/issue770/block/md127/md/dev-sdn
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/dev-sdn/state
Lines: 1
in_sync
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/issue770/block/md127/md/dev-sdo
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/dev-sdo/state
Lines: 1
in_sync
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/issue770/block/md127/md/dev-sdp
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/dev-sdp/state
Lines: 1
faulty
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/level
Lines: 1
raid1
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/metadata_version
Lines: 1
1.2
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/raid_disks
Lines: 1
3
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/sync_action
Lines: 1
resync
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/sync_completed
Lines: 1
delayed
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Path: fixtures/sys/issue770/block/md127/md/uuid
Lines: 1
7615b98d-f2ba-4d99-bee8-6202d8e130b9
Mode: 644
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Directory: fixtures/sys/kernel
Mode: 755
# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Expand Down