Add node 26 to the test matrix.#759
Open
jdmarshall wants to merge 1 commit into
Open
Conversation
cjihrig
approved these changes
Jul 2, 2026
cjihrig
left a comment
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
I think the CI wants a changelog entry, but happy to see this.
Contributor
Author
I don't think we need a changelog for every single chore, but this one might rate a mention... |
jdmarshall
force-pushed
the
node26
branch
2 times, most recently
from
4595cab to
c98412c
Compare
cjihrig
approved these changes
Jul 2, 2026
cjihrig
left a comment
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The only thing I'm unsure of is whether or not you want to update the engines field in package.json. Right now it has >=24, which covers this. I'm just not sure what the project's stance is. That range would also cover Node 25, for example, which may or may not be supported by the project, but is technically EOL.
Signed-off-by: Jason Marshall <jdmarshall@users.noreply.github.com>
cjihrig
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.