Skip to content

Fix the awaitable collect() calls. #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
farcaller wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Fix the awaitable collect() calls. #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/counter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class Counter extends Metric {
async get() {
if (this.collect) {
const v = this.collect();
if (v instanceof Promise) await v;
if ((v instanceof Promise) || (v.then instanceof Function)) await v;
}

return {
Expand Down
2 changes: 1 addition & 1 deletion lib/gauge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class Gauge extends Metric {
async get() {
if (this.collect) {
const v = this.collect();
if (v instanceof Promise) await v;
if ((v instanceof Promise) || (v.then instanceof Function)) await v;
}
return {
help: this.help,
Expand Down
2 changes: 1 addition & 1 deletion lib/histogram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class Histogram extends Metric {
async getForPromString() {
if (this.collect) {
const v = this.collect();
if (v instanceof Promise) await v;
if ((v instanceof Promise) || (v.then instanceof Function)) await v;
}
const data = Object.values(this.hashMap);
const values = data
Expand Down
2 changes: 1 addition & 1 deletion lib/summary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class Summary extends Metric {
async get() {
if (this.collect) {
const v = this.collect();
if (v instanceof Promise) await v;
if ((v instanceof Promise) || (v.then instanceof Function)) await v;
}
const hashKeys = Object.keys(this.hashMap);
const values = [];
Expand Down