Skip to content

feat(DCT-91): map video fields on AITB Dataset - #465

Merged
dessskris merged 4 commits into
mainfrom
dct-91-map-video-fields
Jul 22, 2026
Merged

feat(DCT-91): map video fields on AITB Dataset#465
dessskris merged 4 commits into
mainfrom
dct-91-map-video-fields

Conversation

@dessskris

@dessskris dessskris commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Adds video_url as a supported AI Task Builder dataset schema field, mirroring the existing audio_url support, and adds a manual test script for the video batch preview flow.

What changed

video_url dataset schema support

  • Added video_url to the allowed dataset schema field types
  • Updated dataset schema validation errors to include video_url
  • Updated aitaskbuilder dataset create --schema help text and inline examples
  • Added video_url to docs/examples/dataset-schema.json
  • Extended schema validation tests to cover video_url

Video URL validation on dataset upload

  • Added validation for video_url columns in both CSV and JSONL uploads
  • Rejects unsupported video URLs unless they end with one of:
    • .mp4
    • .mov
    • .webm
  • Refactored the audio/video URL validation into shared generic helpers to avoid duplicating the CSV/JSONL scanning logic

Manual test scripts

  • Moved scripts/manual-tests/test_audio_batch_preview.go into its own audio_batch_preview subdirectory, since a second package main script can't live alongside it in a flat directory
  • Added scripts/manual-tests/video_batch_preview, a manual end-to-end script exercising dataset creation with a video_url field, upload validation, and batch preview

Test plan

  • go test ./...
  • golangci-lint run
  • Manual run of scripts/manual-tests/video_batch_preview against a real workspace confirmed the flow end-to-end

Adds video_url as a supported AI Task Builder dataset schema field
type, mirroring the existing audio_url support, and validates video
URL extensions on dataset upload. Also moves the manual batch-preview
test scripts into per-script subdirectories so multiple package main
scripts can coexist under scripts/manual-tests, and adds a video
equivalent of the audio preview script.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@prolific-snyk

prolific-snyk commented Jul 21, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@dessskris dessskris changed the title DCT-91 Map video fields feat(DCT-91): map video fields on AITB Dataset Jul 21, 2026
@dessskris
dessskris marked this pull request as ready for review July 21, 2026 18:42
@dessskris
dessskris requested a review from a team as a code owner July 21, 2026 18:42
Copilot AI review requested due to automatic review settings July 21, 2026 18:42
@dessskris
dessskris requested a review from a team as a code owner July 21, 2026 18:42
@dessskris dessskris added team-dct customer-facing dct-ready-for-review Triggers Slack notification when PR is ready for review labels Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds video_url as a first-class typed dataset schema field for AI Task Builder, extending the existing audio_url behavior to dataset schema parsing/validation, dataset upload validation, documentation examples, and manual end-to-end preview testing.

Changes:

  • Extend typed dataset schema support to allow video_url (including CLI help text + example schema JSON).
  • Add upload-time validation for video_url columns in CSV/JSONL and refactor audio/video URL validation into shared helpers.
  • Add a new manual test script for the video batch preview flow and adjust the audio manual script directory structure.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/manual-tests/video_batch_preview/main.go New manual end-to-end script for dataset creation/upload + batch preview using video_url.
scripts/manual-tests/audio_batch_preview/main.go Updates repo-root resolution after moving the audio manual test into a subdirectory.
docs/examples/dataset-schema.json Adds video_url to the example typed schema.
cmd/aitaskbuilder/upload_dataset.go Adds video_url upload validation and refactors media URL validation into shared helpers.
cmd/aitaskbuilder/upload_dataset_test.go Extends tests to cover invalid video_url uploads and JSONL validation.
cmd/aitaskbuilder/dataset_schema.go Allows video_url as a valid dataset schema field type and updates the invalid-type error message.
cmd/aitaskbuilder/dataset_schema_test.go Updates schema parsing tests to include video_url.
cmd/aitaskbuilder/create_dataset.go Updates --schema help text to include video_url in the documented field types.

Comment thread cmd/aitaskbuilder/upload_dataset.go Outdated
Comment thread scripts/manual-tests/video_batch_preview/main.go
Comment thread cmd/aitaskbuilder/upload_dataset.go
Audio and video URL validation each scanned the upload file fully,
doubling read time for datasets with both field types.
@dessskris
dessskris enabled auto-merge (squash) July 22, 2026 12:25
@dessskris
dessskris merged commit 470db32 into main Jul 22, 2026
6 checks passed
@dessskris
dessskris deleted the dct-91-map-video-fields branch July 22, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-facing dct-ready-for-review Triggers Slack notification when PR is ready for review team-dct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants