Repository navigation
Conversation
See https://github.com/snow-actions/eclint Also add it to the makefile that you can locally fix editorconfig issues. Include editorconfig fix in make format.
|
|
||
| .PHONY: format_editorconfig | ||
| format_editorconfig: ## Fix EditorConfig issues | ||
| npx --yes eclint@$(ECLINT_VERSION) fix . |
There was a problem hiding this comment.
Do you realize that this won't work on everyone's machine? Please use a suitable docker image (the same way we do for Jsonnet etc.) instead of directly invoking a CLI tool that may or may not exist on a machine.
There was a problem hiding this comment.
Some have even problems with docker. Ok, will do.
There was a problem hiding this comment.
Well, if you have problems with docker or podman, you won't have any luck running any Commodore component stuff locally without custom magic.
edit: if you structure the helper variables the same as what we have for Commodore, yamllint and Jsonnet in Makefile.vars.mk, users will be able to use their local npx by overriding NPX_CMD (if modelled after COMMODORE_CMD) or NPX_DOCKER (if modelled after JSONNET_DOCKER and YAMLLINT_DOCKER).
|
|
||
| .PHONY: format | ||
| format: format_jsonnet ## All-in-one formatting | ||
| format: format_jsonnet format_editorconfig ## All-in-one formatting |
There was a problem hiding this comment.
If we're adding a new format_ make target for editorconfig, we should add the equivalent target for linting, see above in the template Makefile.
See https://github.com/snow-actions/eclint
Also add it to the makefile that you can locally fix editorconfig issues.
Include editorconfig fix in make format.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
- [] Update the documentation.bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.