Repository navigation
Add support for namespace labels and annotations to generated components - #185
bacluc-agent wants to merge 1 commit into
Conversation
Lets new components set namespaceLabels/namespaceAnnotations and toggle createNamespace.
6770b2f to
fabd00e
Compare
|
I cleaned up the PR of the agent, should be good to review now. |
|
Although I don't know how all this magic works, there appear to be some test jobs in the pipeline. If it is not too much work and maybe AI can help, I think it would make sense to have this basic feature inside a test. |
Done: the template now has a |
|
Please recreate this PR from a branch on this repo so the dry-run sync job has access to the SSH private key. I want to see how much chaos this generates before merging it. |
There was a problem hiding this comment.
Please recreate this PR from a branch on this repo so the dry-run sync job has access to the SSH private key. I want to see how much chaos this generates before merging it.
To elaborate: It's quite likely that the changes proposed in this PR will cause merge conflicts in (almost) all existing components.
Will do |
From https://github.com/projectsyn/component-external-secrets-operator/pull/13/changes
and then we had to do the same for multiple components.
Most component can make use of creating a namespace...and can make use of namespace labels and annotations.
That way its the same everywhere.
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
- [] Update the documentation.bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.
Test evidence
cruft update -p ... --template-path /tmp/commodore-component-template -c issue-73-namespace-meta -yupdated
.cruft.jsonbut could NOT auto-apply the 3 files (they diverged from template pristine content →.rejfiles). After manually porting the 3 changes,make test -e instance=defaultscompiled andmake gen-golden golden-diffpassed;