[master/4.2] Fix HLSLParser: Always check preprocessor directive stack#994
Merged
kblaschke merged 1 commit intoMay 8, 2026
Conversation
kblaschke
requested review from
blaquewithaq,
dpw13,
mbaetgen-wup,
revmischa and
struktured
2 tasks
… before using the top element
kblaschke
force-pushed
the
fix/hlslparser-unmatched-preprocessor-directives
branch
from
45eae36 to
76c8ff7
Compare
mbaetgen-wup
approved these changes
May 7, 2026
|
Might be worth making explicit that one PR puts these fixes on Master and one puts fixes on the 4.1.x branch. |
kblaschke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was previously dereferencing the top element without checking for the stack to be empty (e.g. if there are mismatched preprocessor directives). The loop now aborts if there is at least one more closing directive (e.g.
#endif) than opening ones.