Skip to content

FGD cleanup#36

Draft
SirYodaJedi wants to merge 7 commits into
progs-dump-dev:mainfrom
SirYodaJedi:fgd_cleanup_jack
Draft

FGD cleanup#36
SirYodaJedi wants to merge 7 commits into
progs-dump-dev:mainfrom
SirYodaJedi:fgd_cleanup_jack

Conversation

@SirYodaJedi

@SirYodaJedi SirYodaJedi commented Feb 16, 2025

Copy link
Copy Markdown

Some notable changes:

  • Verify feature parity between Trenchbroom and Jack FGDs
  • Move long SmartEdit names to descriptions
  • Move relevant key and flag descriptions from entity description to KV description
  • Move Trigger baseclass to baseclass section, so that trigger_filter doesn't cause an error
  • Remove linebreak statements from trigger_textstory and target_textstory, since it gets interpreted as an actual line break
  • Add sequence() and skin() to Jack FGD where appropriate
  • Remove several dangerous default values from Jack FGD, as default values are autofilled by the editor
  • Add some editor sprites to the Jack FGD (they're bundled with Jack)
  • Add sequence variable to defs.qc, because Jack needs it to preview animation frames reverted
  • Add some comments indicating where changes would be necessary to use Jack FGD with NRC.

Still working on fixing some syntax errors, but it's 98% done, so I figured I'd push a draft PR to get feedback. This PR is a bit messy, though, so I might need to close it and open a new one if it is to be pushed.

@jjelliott jjelliott left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with doing this, but I was actually thinking of deleting this as I have no interest in maintaining it anymore, so don't be surprised if it gets out of date again.

Comment thread fgd_def/pd_300_JACK.fgd
Comment thread qc/defs.qc Outdated
Comment thread qc/defs.qc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think that as we recommend TB, the default FGD being the TB one is preferable. I'll let @dumptruckDS weigh in on this if he wants but I would prefer this not being renamed.

@SirYodaJedi SirYodaJedi Feb 16, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme and manual actually don't specify a recommended editor. Reverted for now, so that the changes can be read.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very late to the party but I really would prefer to prioritize TB as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants