0.2.2: spoof check skips declared crawlers (Googlebot evergreen UA) - #3
Merged
Merged
Conversation
Googlebot's evergreen user agent claims Chrome and sends no Sec-Fetch-Mode, so 0.2.0's spoof check would have charged Google -- and Bing -- the moment a site switched it on. Caught on rssamplifier before it shipped, by the site's own exemption; now the library refuses to judge anything that says "compatible;", "bot", "crawler", "spider" or "slurp". Those are charged by the lists or not at all. The check is for the client that declares nothing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WJaXiqE9BDoNfoJBhfXroC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isSpoofedBrowsernow returns false for any user agent that declares itself (compatible;,bot,crawler,spider,slurp). Googlebot and Bingbot claimChrome/…and send noSec-Fetch-Mode, sochargeSpoofedBrowserswould have charged them. Tests added for the evergreen Googlebot, Bingbot and Applebot strings.🤖 Generated with Claude Code
https://claude.ai/code/session_01WJaXiqE9BDoNfoJBhfXroC