Conversation
`clientIp` took the first X-Forwarded-For entry, which is whatever the client chose to send, so a denylist read from it was a denylist any client could step around by sending one. The entry our own edge appends is the last, on Railway's proxy and on nginx alike, and nginx's X-Real-IP is the same hop set from the socket. Both are now preferred over anything the client seeded. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WJaXiqE9BDoNfoJBhfXroC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clientIpread the firstX-Forwarded-Forentry, which a client can seed, sodenyCidrscould be stepped around by sending one. Now:X-Real-IPwhen present (nginx sets it from the socket), else the lastX-Forwarded-Forhop (the one Railway's proxy or nginx appends).🤖 Generated with Claude Code
https://claude.ai/code/session_01WJaXiqE9BDoNfoJBhfXroC