Keep browser address edits and recover failed navigation - #101
Merged
Merged
Conversation
ThreatCrush Security Scan51 finding(s) MEDIUM: 32 | LOW: 19
…and 1 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
ralyodio
marked this pull request as ready for review
September 14, 2026 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
da3ff4dpassed 9 focused checks on an offline Android 11/API30 emulator: pixel coverage at density160/240, Retry/loading cycle, address edit and keyboard Back, tab isolation/restoration, and a compressed accessibility-tree check. The previously exposed 5px band was fully background. No APK/JS bundle substitution was used. These native checks predate the subsequent five-line Stop callback fix; that fix has component/JS-library tests, not a new native runtime claim.Native Release Gate
This is the Expo companion app, not the native Chromium engine. The original updated APK from Mobile CI ran on an offline Android 11/API30 emulator and confirmed the overlay fix at two densities. No successful online navigation, real TalkBack traversal, native iOS or physical-device run is claimed by that test. Before release, verify editing during redirects, same-source submit, Back/Forward, network/TLS failure and manual retry on each native engine.
Recovery remount intentionally discards native history. Native callbacks have no request ID: stopping and immediately reopening the SAME URL may still receive an old callback indistinguishable from the new load. A late redirect target not recorded in the superseded set and events older than the bounded 16-URL history also remain limitations. The fix targets replacement by a DIFFERENT URL; it is not universal native request correlation.
No paid EAS build, production deployment or store submission was triggered.