The hub record advertises its public base, not localhost - #212
Merged
Conversation
Caught the moment it went live. Behind Railway the request origin is the internal one, so the record built from it told every client to call back on https://localhost:3000, which makes the whole thing useless to anyone reading it. It now takes NEXT_PUBLIC_APP_URL first and the request origin only as the local fallback, exactly as the seedbox, IPTV and VOD rails already do it. Regression test on both paths. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SKAohrRkqLKVQL2cGCAkR5
ThreatCrush Security Scan99 finding(s) HIGH/CRITICAL: 11 | MEDIUM: 29 | LOW: 59
…and 49 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught the moment the hub went live. Behind Railway the request origin is the internal one, so
/.well-known/openswarm-hub.jsontold every client to call back onhttps://localhost:3000:It now takes
NEXT_PUBLIC_APP_URLfirst and the request origin only as the local fallback, the way the seedbox, IPTV and VOD rails already do it. Regression test covers both paths.🤖 Generated with Claude Code
https://claude.ai/code/session_01SKAohrRkqLKVQL2cGCAkR5