ads: surface the Text Link size on the Monetize page - #98
Merged
Merged
Conversation
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
Add the native, full-width text-link ad to the publisher size picker. Unlike the banners, text_link predates the ad_slots.formats default, so a migration widens the default and backfills existing slots — otherwise serveAd() would gate it out and the copied embed would never fill. - lib/ads/formats.ts: add text_link to PUBLISHER_FORMAT_IDS - supabase/migrations: allow text_link on ad_slots.formats (+ backfill) Note: prod migration history has diverged, so this must be applied by hand via psql over the pooler (see the crawlproof-alerts runbook), not `supabase db push`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ralyodio
force-pushed
the
ads/format-text-link
branch
from
July 17, 2026 07:27
626fe99 to
465ba82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the native, full-width Text Link ad to the publisher size picker on
/ads/slots.Changes
lib/ads/formats.ts— appendtext_linktoPUBLISHER_FORMAT_IDS.supabase/migrations/20260717130000_ad_slot_text_link_format.sql— widen thead_slots.formatsdefault to includetext_linkand backfill existing slots.Why the migration
Unlike the banner sizes,
text_linkpredates thead_slots.formatsdefault.serveAd()gates fills to a slot'sformatsarray, so without widening it a publisher who pastes the text-link embed would get nothing back. The migration fixes both new slots (default) and existing ones (backfill).Per the crawlproof runbook, prod migration history has diverged and
supabase db pushis blocked — apply this migration viapsqlover the pooler after merge, or the text-link embed won't fill in production.Notes
PUBLISHER_FORMAT_IDSlist (rebase = one line).ad.jshandling already exist.🤖 Generated with Claude Code