ci(prober): npm ci fallback to npm install (robust self-bootstrapping deploy) - #81
Merged
Merged
Conversation
…ock) The deploy-prober run failed at 'npm ci' because prober/package-lock.json was absent at that commit. Harden provision.sh so a missing or out-of-sync lockfile falls back to 'npm install' instead of hard-failing the self-bootstrapping deploy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
deploy-proberrun failed at the prober build step:At that commit
prober/package-lock.jsonwasn't committed yet. It exists on master now (lockfileVersion 3, bullmq/ioredis in sync), so a re-run would already pass — but a self-bootstrapping deploy shouldn't hard-fail on a missing/stale lock.Fix
npm ci … || npm install …inprovision.sh. Reproducible install when the lock is good; graceful fallback otherwise.🤖 Generated with Claude Code