Alerts: make /alerts public, require sign-in to save - #74
Merged
Merged
Conversation
Anyone can open /alerts and build an alert (category, term, recency, frequency). Saving requires an account: for anonymous visitors the Create button routes to /login?redirect=/alerts?new=... so the built alert is created immediately after sign-in. Signed-in users get the full dashboard. Moved from the auth-gated (app) group into (marketing) (auth-adaptive header, no forced redirect). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/alertsis now publicly viewable — anyone can open it and build an alert (category, term, recency, frequency). Saving requires an account./login?redirect=/alerts?new=<cat>&term=<term>&recency=<r>&frequency=<f>, so the alert they built is created immediately after sign-in (the page reads those params post-auth). A "Log in" link is shown too.(app)group into(marketing)(which has the auth-adaptive header and no forced redirect). The instant test-run stays signed-in-only (it spends SERP budget).Verified locally: anonymous
GET /alerts→ 200 (previously 307→/login). App + workertsc --noEmitclean.Builds on merged #72 and #73.
🤖 Generated with Claude Code