Repository navigation
Fix cookie sameSite normalization for browser posting - #64
Merged
Merged
Conversation
Cookie-Editor / Chrome cookie exports use sameSite spellings that Playwright rejects — "no_restriction", "unspecified", lowercase "lax"/"strict", or null — causing every browser-automated post to fail at ctx.addCookies with: cookies[N].sameSite: expected one of (Strict|Lax|None) parseCookies now maps those to Playwright's exact enum (no_restriction → None, strict → Strict, everything else → Lax) and forces Secure on SameSite=None cookies, which Chromium rejects otherwise. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Every browser-automated social post (and the new Retry button) was failing at cookie load:
Playwright's
addCookiesonly acceptssameSiteof exactlyStrict|Lax|None, but Cookie-Editor / Chrome exports use other spellings —no_restriction,unspecified, lowercaselax/strict, ornull.parseCookiespassed those through unchanged (it only defaulted when the field was nullish), so any cookie with such a value blew up the whole post.Fix
normalizeSameSitemaps every input to Playwright's enum:strict→Strictnone/no_restriction→Nonelax/unspecified/""/null/ anything else →LaxIt also forces
Secure: trueonSameSite=Nonecookies, which Chromium rejects otherwise (a second error you'd hit right after fixing the enum).Verification
tsc --noEmitcleantests/sp/*32/32, incl. newparse-cookies.test.tscovering the spelling map, the Secure-for-None rule, and the{ cookies: [...] }wrapper form🤖 Generated with Claude Code