Skip to content

Promote a creative to ready when its revision publishes #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Sep 24, 2026
Merged

Promote a creative to ready when its revision publishes #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion worker/video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,22 @@ async function publishRevision(
): Promise<boolean> {
const { data } = await supabase
.from("ad_creatives")
.update({ published_revision: args.revision })
.update({
published_revision: args.revision,
// Promoted out of "generating" in the same write.
//
// The row is created as "generating" so nothing serves a creative that
// has no bytes yet, and publishing the revision IS the moment it gains
// them — but the status was never moved, so all 185 video creatives sat
// at "generating" with validated media behind them. Selection only
// considers "ready", so every streaming break fell through to the house
// ad: the whole pipeline worked and nothing could ever be served.
//
// Same write as published_revision deliberately. Two statements could
// leave a creative servable-by-status with no published revision, or the
// reverse, and the compare-and-swap below protects both together.
status: "ready",
})
.eq("id", args.creativeId)
.eq("requested_revision", args.revision)
.select("id");
Expand Down