Ship the music bed file itself - #298
Merged
Merged
Conversation
…hing Generated with ElevenLabs: 24 seconds, instrumental, deliberately even with no builds or drops, because the encoder takes whatever five second window it lands on and a riser halfway through would be most of what you hear. Measured -19.2 to -19.8 dB across its windows, so the level does not lurch depending on where the trim falls. The generated tail was three dB quieter than the rest and is cut off rather than shipped. AD_MUSIC_BED still overrides it. The default is bundled rather than required because an advert that needs an environment variable set before it sounds finished will ship unfinished. Missing from disk, the spot is voice only rather than failing: a bed is the least important thing in the file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#293 merged the mixing but not the audio, because the file was pushed after the squash. Master can mix a bed today, it just has no bed to mix unless
AD_MUSIC_BEDis set.This adds the file and makes it the default.
Generated with ElevenLabs: 24 seconds, instrumental, deliberately even with no builds or drops, because the encoder takes whatever five second window it lands on and a riser halfway through would be most of what you hear.
Measured across its windows:
The generated tail was three dB quieter than the rest and is cut off rather than shipped.
AD_MUSIC_BEDstill overrides it. The default is bundled rather than required because an advert that needs an environment variable set before it sounds finished will ship unfinished. Missing from disk, the spot is voice only rather than failing: a bed is the least important thing in the file.🤖 Generated with Claude Code