ops: chown .deploy-state to the deploy user - #297
Merged
Merged
Conversation
Running deploy-app.sh once as root during the initial migration leaves a root-owned .deploy-state. Every later CI deploy then builds, restarts and passes its health check, and fails on the very last line writing that file - so the deploy is reported failed while the site is actually running the new code, which is the worst possible way for this to break. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #296, found by the first real CI deploy.
Running
deploy-app.shonce as root during the migration leaves a root-owned.deploy-state. Every later CI deploy then builds, restarts the container and passes its health check, and fails on the very last line writing that file — so the run is reported failed while the site is actually serving the new code, which is the worst way for this to break.Already fixed on dev2; this makes
setup-app-host.shdo it so a fresh host does not repeat it. The next deploy run (36053550657) is green end to end: fetch → build → start → healthy →crawlproof.com 200.