Pad the narration to the length of the picture - #292
Merged
Merged
Conversation
Every narrated render failed validation. The voiceover for a five-second ad is about two and a half seconds of speech, so the audio stream ended early and the duration check — which requires picture and sound to agree within one AAC frame — rejected all of them: audio duration expected 5000ms, got 2346.000ms (drift 2654.000ms) apad extends the audio with silence indefinitely and -shortest then trims the result back to the video's five seconds, so the track is exactly as long as the picture. This is worth doing beyond the check: a player handed a track that ends early is entitled to stop there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every narrated render failed validation:
The voiceover for a five-second ad is about two and a half seconds of speech, so the audio stream ended early and the duration check — which requires picture and sound to agree within one AAC frame — rejected all of them.
apadextends the audio with silence indefinitely and-shortestthen trims the result back to the video's five seconds, so the track is exactly as long as the picture.Worth doing beyond satisfying the check: a player handed a track that ends early is entitled to stop there.
Narration itself is confirmed working in production — 87 KB of audio, script "Crypto Payments, No Custody. Get started free at coinpayportal.com." — and the three animated banners rendered in the same job. This was the last thing between that and a finished revision.
2581 passed / 1 failed (pre-existing tracker-geo). Typechecks clean.