Email tab: use the dashboard's fetchJson; exact CLI test lines (CodeQL follow-up to #268) - #269
Merged
Merged
Conversation
…lines CodeQL flagged the Email tab's hand-rolled token fetch (js/file-access-to-http) and an unanchored hostname regex in a test. The tab now calls listEmailTracking/setEmailTracking in lib/dashboard/collect.ts, the same timed, token-authed helper every other feed uses, and the CLI test compares whole lines. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #268. It merged at its first commit; this fix was pushed a moment later and missed it.
CodeQL flagged three new alerts on #268:
js/file-access-to-http: the TUI Email tab's hand-rolled token fetch. The tab now callslistEmailTrackingandsetEmailTrackinginlib/dashboard/collect.ts, through the same timed, token-authedfetchJsonevery other feed uses.fetchJsongains amethodargument for the POST. This also gets the 20 s timeout the hand-rolled fetch lacked.js/regex/missing-regexp-anchor(high, test only): the CLI test now compares whole lines instead of an unanchored regex.Tests: tsc clean; email-tracking + dashboard suites pass (39).
🤖 Generated with Claude Code