Square off the ad container so the corners stop showing white - #210
Merged
Merged
Conversation
The iframe the embed drops in is square, but .cp-ad rounded its own corners at 8px, so the host page background bled through the four corners of every unit. Set the radius to 0 on all five container rules (house banner and text link, paid creative banner and text link, and the terminal ad). Inner chrome -- CTA pill, logo, brand badge -- keeps its own radius. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan35 finding(s) HIGH/CRITICAL: 3 | MEDIUM: 23 | LOW: 9
Snippets are redacted; ThreatCrush never prints matched credential material. |
ralyodio
added a commit
that referenced
this pull request
Aug 19, 2026
#210 set border-radius to 0 on the five ad container rules, in exactly the lines this branch rewrote for light/dark. Resolved by keeping both: the containers stay square, and the palette and hairline stay theme-aware. Also squared off the three container radii in the React <AdPreview>, which #210 missed. That component exists to mirror renderCreativeHtml, so a rounded preview of a square unit is the drift it is there to prevent. Inner chrome (logo, monogram, CTA pill) keeps its radius, and so does the feed card, which mocks a reader's own sheet rather than an ad container in an iframe. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embed iframe is square, but
.cp-adrounded its own corners at 8px, so the host page background bled through all four corners of every unit.Sets
border-radius:0on all five.cp-adcontainer rules:lib/ads/house.ts— house text link + house bannerlib/ads/creative.ts— paid text link + paid banner/rectlib/ads/terminal.ts— terminal adInner chrome (CTA pill, logo, brand badge) keeps its own radius.
Checks:
tsc --noEmitclean apart from one pre-existingfast-xml-parsermodule-resolution error unrelated to this change;tests/contract/ads-terminal.test.ts+tests/ads-stats-box.test.tspass (37 tests).🤖 Generated with Claude Code