fix(docs): mention stats-tracker alias on /docs index - #179
Merged
Merged
Conversation
Several places in the app link to /docs/stats-tracker (github integration page, getting-started wizard, install-tracker script), but the /docs index page only listed /docs/statistics. Users following those internal links would land on the right page but never see it in the docs navigation. Add a note in the Statistics card copy so anyone arriving from those links can find the canonical entry in the docs index.
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ralyodio
added a commit
that referenced
this pull request
Aug 3, 2026
serveAd diverts HOUSE_AD_ROTATION_RATE (~10%) of otherwise-fillable requests to the house ad, which is unmetered: no impression row, so no short code and no /a/ click URL. Four of the five tests in this file read fields off whatever came back, so each failed on ~10% of runs — about one CI run in three went red, on whichever test happened to draw the house ad. Measured on master before this change: 6 of 15 runs failed, across four different tests. That is what took down the builds on #179 and #183, neither of which touches ads. These tests are about the click URL of a *paid* fill, so the draw is pinned above the threshold. Fixing Math.random is safe precisely here: the auction has a single candidate either way, and short codes come from crypto.randomBytes, so "issues a distinct code per paid fill" still exercises real entropy — and now checks all 60 fills instead of a subset that silently shrank whenever the house ad turned up. Pinning the draw would have deleted the only coverage of the rotation, so it is asserted directly rather than left to chance: one test for a draw under the rate, one for a draw exactly on it. The boundary is the interesting part, and sampling the rate would just be a slower way to reintroduce a flaky test. 40 consecutive runs of the file now pass, against 9 of 15 before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ralyodio
force-pushed
the
fix/docs-index-stats-tracker
branch
from
August 3, 2026 15:05
e87017a to
5e9063d
Compare
ThreatCrush Security Scan52 finding(s) HIGH/CRITICAL: 10 | MEDIUM: 42
…and 2 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
ralyodio
force-pushed
the
fix/docs-index-stats-tracker
branch
from
August 3, 2026 15:08
5e9063d to
53aa51c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several places in the app link to /docs/stats-tracker (github integration page, getting-started wizard,
install-tracker script), but the /docs index page only listed /docs/statistics. Users following those internal links would land on the right page but never see it in the docs navigation.
Add a note in the Statistics card copy so anyone arriving from those links can find the canonical entry in the docs index.