Skip to content

ci(gitleaks): gate PRs on their own commits, pin two more false positives #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 30, 2026
Merged

ci(gitleaks): gate PRs on their own commits, pin two more false positives #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,20 @@ jobs:
curl -sSL "https://github.com/gitleaks/gitleaks/releases/download/v${VERSION}/gitleaks_${VERSION}_linux_x64.tar.gz" \
| tar -xz -C /usr/local/bin gitleaks
gitleaks version
# A pull request is gated on what IT introduces. Scanning full history
# here failed every PR in the repo on the same historical blob, no matter
# what the PR touched — and a check that is red on arrival is a check
# nobody reads. The history is still scanned, on master and on the weekly
# cron below, so a finding cannot be merged out of sight.
- name: Scan pull request commits
if: github.event_name == 'pull_request'
run: |
gitleaks detect --source . --redact --verbose --no-banner --exit-code 1 \
--log-opts="--no-merges ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }}"

# push to master + schedule: everything, forever. This is what surfaces
# credentials already committed; it stays red until they are rotated and
# the blob is purged from history.
- name: Scan history
if: github.event_name != 'pull_request'
run: gitleaks detect --source . --redact --verbose --no-banner --exit-code 1
11 changes: 11 additions & 0 deletions .gitleaksignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,14 @@
# tag fixture for the tracker integration analyzer test. Not a real secret —
# it's asserted on by the test, so pin the historical blob rather than rewrite.
64a771186801871e191fb913b801b086d9ef3235:tests/contract/tracker-integrations.test.ts:generic-api-key:8

# A fingerprint pins one commit, and both lines above survived edits to their
# files, so the same non-secret matches again under every later SHA that still
# carries the line. These are the remaining occurrences of the two entries
# above — same lines, same verdict, later commits.
#
# 2eb14f9b: the same pk_test_ fixture.
2eb14f9b73d3100d207b41ea23d216ee2100acc9:tests/contract/tracker-integrations.test.ts:generic-api-key:8
# 508859ed: the same curl example, by then reading `-H "Authorization: Bearer
# $SECRET"` — a shell variable the reader substitutes, not a token.
508859ed12ff73cd5044a4fd10971372779578cb:app/(marketing)/docs/autoblog-webhook/page.tsx:curl-auth-header:130
Loading