Repository navigation
ads: auto-install drops every size above </body> (not smart placement) - #100
Merged
Merged
Conversation
The Monetize page's "Submit PR to install" installed a single size and tried to place a leaderboard at the top of the page. We can't reliably tell where each size belongs without understanding the target page, so instead inject a unit for EVERY available size (PUBLISHER_FORMAT_IDS) stacked before </body>, sharing one /ad.js loader. Publishers keep or move whichever they want; empty units simply don't render. - lib/github/install-ad.ts: embedBlock stacks all sizes before </body> with a single loader; drop the top-placement / single-format paths - app/api/ads/slots/[id]/install-embed: no per-format param (installs all) - components/ads/slot-manager.tsx: install button says "install all sizes" and sits below the per-size copy area - tests: auto-install emits every size + one loader, all above </body> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Monetize page's "Submit PR to install" installed a single size and tried to place a leaderboard at the top of the page. We can't reliably tell where each size belongs without understanding the target page, so instead inject a unit for EVERY available size (PUBLISHER_FORMAT_IDS) stacked before , sharing one /ad.js loader. Publishers keep or move whichever they want; empty units simply don't render.
with a single loader; drop the top-placement / single-format paths