fix(banking): ACH pay-in routes answered 404 for every real payment - #359
Merged
Merged
Conversation
The payment loader selected a `description` column that payments does not have (it lives in metadata), so PostgREST returned an error, the loader returned null and the route answered "Not found" for a real pending payment. Verified live on prod right after #358 deployed. - Read description from payments.metadata. - Load the business with a second plain query in both routes rather than an embedded join, so neither depends on relationship resolution. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ThreatCrush Security Scan331 finding(s) HIGH/CRITICAL: 33 | MEDIUM: 40 | LOW: 258
…and 281 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The payment loader selected a
descriptioncolumn thatpaymentsdoes not have (it lives in metadata), so PostgREST errored, the loader returned null, and the public ACH route answered 404 for a real pending payment. Verified live right after #358 deployed.payments.metadata.tsc --noEmitexits 0; pre-commit tests green.🤖 Generated with Claude Code