0.9.0: an unpaid role can say so - #41
Merged
Merged
Conversation
There was no way to post an unpaid internship. Leaving the salary range empty already meant "the employer did not fill this in", so an honest unpaid listing was indistinguishable from a careless one, and putting 0 in the range made it sort and filter as a paid job worth nothing. salary.unpaid is a boolean for exactly that reason. When it is set the range stays null, so every salary filter and the salary sort keep excluding these listings with no special case anywhere, and the page prints "Unpaid" instead of nothing. Unpaid wins over any number that arrives with it. A form can post a stale range alongside a ticked box, and "unpaid, $40k - $60k a year" is not a listing anybody can act on. Reachable from every surface that can post: a checkbox on /post, the salaryUnpaid field on the API, --salary-unpaid on the CLI, and salary_unpaid in job file front matter, which already camel-cased its way through. schema.org has no vocabulary for unpaid work, so baseSalary is simply absent, which is what it already did for a null range. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015xXMzJf85q87oeG3VEKHdJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no way to post an unpaid internship.
Leaving the salary range empty already meant "the employer did not fill this in", so an honest unpaid listing was indistinguishable from a careless one. Putting
0in the range was worse: it sorts and filters as a paid job worth nothing.salary.unpaidis a boolean for that reason. When it is set the range stays null, so every salary filter and the salary sort keep excluding these listings with no special case anywhere, and the page prints Unpaid instead of nothing.Unpaid wins over any number that arrives with it. A form can post a stale range alongside a ticked box, and "unpaid, $40k - $60k a year" is not a listing anybody can act on.
Every surface that can post
/postsalaryUnpaid: true--salary-unpaidsalary_unpaid: true(already camel-cased its way through)schema.org has no vocabulary for unpaid work, so
baseSalaryis simply absent, which is what it already did for a null range.docs/openjob.mdsays so.Testing
173 pass. Six new: that "not stated" and "unpaid" format differently, that unpaid clears a range posted alongside it, that a checkbox
"on"and an APItrueland in the same column, that an absent checkbox reads as false rather than as unchanged, that the form renders the control and returns it still ticked on a rejected submit, and an end-to-end one against a real Postgres that posts an unpaid listing, reads it back through the read path, and confirms it does not match?salaryMin=1.🤖 Generated with Claude Code