ci(deploy): retry the :22 smoke test instead of failing on the first probe - #137
Merged
Merged
Conversation
The redeploy restarts agentbbs, and the smoke test could run before it had re-bound :22 (0.3 s after on the #136 deploy). One probe made most deploys go red while the BBS answered moments later. Probe up to 12 times, 10 s apart, and fail only if :22 never answers. Still a keyscan only, so no account is ever registered. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan10 finding(s) HIGH/CRITICAL: 7 | LOW: 3
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy job's ":22 smoke test" has failed on 4 of the last 5 deploys while agentbbs was fine. The redeploy step restarts agentbbs, and the smoke test runs immediately after: on the #136 deploy it probed 0.3 s after the restart, before :22 was re-bound.
Change: probe up to 12 times, 10 s apart (about 2 minutes), pass on the first answer, fail only if :22 never comes back. It still uses
ssh-keyscanonly, so it never completes a handshake and never registers an account.Tested: ran the step's script locally. Against bbs.profullstack.com it passes on attempt 1; against an unroutable address it retries and then fails as before.
🤖 Generated with Claude Code