test(ux): repair the audit screenshot suite's dead nav selectors - #1180
Merged
Conversation
The UX-audit suite navigated by clicking [data-nav="directory"], [data-nav="archive"], and [data-nav="events"], none of which the icon rail renders. Those five tests sat on page.click until the 120s timeout instead of capturing anything, so `npm run ux:audit` took 11.1 minutes to report five failures. - "directory" was always a misnomer for the contacts view: UX_REVIEW.md section 6 is titled "Directory (contacts)", and the committed screenshots show the contacts roster. Point the three tests at 'contacts' and rename them and their output files to match what they capture. - The archive stopped being a rail tab when navigation became conversation-first (#789); it is now a toggle in the messages header. Drive it through that toggle instead. - The Events view was dissolved outright by the same change, and nothing replaced it, so drop its capture and mark UX_REVIEW.md section 9 as removed along with the feature. The section number is retained so existing cross-references still resolve. Also correct two stale claims the removal surfaced: room invitations surface in the Rooms list rather than the contacts list, and EVENT_HOOKS.md no longer describes the deleted EventsView as working unchanged. The suite now passes 16/16 in about a minute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run ux:auditnavigated by clicking[data-nav="directory"],[data-nav="archive"], and[data-nav="events"]— none of which the icon rail renders. Five tests sat onpage.clickuntil the 120s timeout instead of capturing anything, so the suite took 11.1 minutes to report five failures.directory→contacts. Always a misnomer, not a drift:UX_REVIEW.md§6 is titled "Directory (contacts)" and the committed screenshots show the contacts roster. The three tests and their output files are renamed to match what they actually capture (04-contacts-list,05-contacts-profile,12-contacts-empty-detail).archivemoved rather than disappeared. Conversation-first navigation: relocate contacts, dissolve Events, in-context reactions #789 turned it from a rail tab into a toggle in the messages header, so the test now drives that toggle.eventswas dissolved outright by the same change, with nothing replacing it. Its capture is dropped and §9 is marked as removed along with the feature. The section number is kept so existing cross-references still resolve.Two stale claims the removal surfaced are also corrected: room invitations surface in the Rooms list (not contacts), and
EVENT_HOOKS.mdno longer describes the deletedEventsViewas working unchanged.The suite now passes 16/16 in about a minute. The three repaired captures were visually confirmed to show the intended views.
Known follow-up, deliberately out of scope: the executive summary, §3, and the §15 checklist still reference the removed Events tab and findings §9.2/§9.4. Reconciling those is tracked separately.