TML-2956: accept ADR 231 and close project workspace - #30149
Merged
Conversation
Signed-off-by: Steven McClankerton <tatarintsev@prisma.io>
Signed-off-by: Steven McClankerton <tatarintsev@prisma.io>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (44)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe ADR changes from Proposed to Accepted. It narrows implementation scope to interpreter-owned SQL and Mongo specifications, revises the combinator and typed function-call model, updates examples and policies, and records deferred language-tooling work. ChangesDeclarative attribute specifications
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR reconciles an architecture document and removes completed project coordination files without changing product behavior; the reported validation checks passed, and no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
SevInf
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Refs TML-2956.
Summary
Closes the typed attribute parsers project after the SQL and Mongo interpreter migrations landed. ADR 231 now records the accepted architecture as implemented, while the completed project coordination workspace is removed.
Changes
ArgType,InterpretCtx, collection, reference,oneOf, and typedfuncCallAPIs. It documents dynamic SQL default and Mongo index specs, accepts the interpreter architecture, and separates current behavior from the language-tooling follow-up.Project DoD verification
@relationlanded in #891.@defaultspecs and typed function calls landed in #938.Testing performed
pnpm lint:deps— no dependency violations across 2,010 modules and 3,121 dependencies.pnpm build— 85/85 tasks passed.pnpm fixtures:check— passed with no generated drift.git diff --check— passed.Skill update
n/a — this PR closes project documentation and reconciles an ADR. The user-facing Mongo syntax migration and executable upgrade instructions landed in #29833.
Checklist
git commit -s) per the DCO.CONTRIBUTING.mdand the change is scoped to one logical concern.TML-NNNN: <sentence-case title>form.Notes for the reviewer
The large deletion is entirely transient project coordination material. ADR 231 is the only retained document and intentionally distinguishes the interpreter implementation from central spec discovery and language-server traversal that have not shipped yet.
Summary by CodeRabbit