chore(deps): move the ORM family to 8.0.0-rc.10 - #291
Conversation
Every @prisma/orm-* pin goes from 8.0.0-rc.8 to 8.0.0-rc.10 (rc.9 was never adopted). Schema files take the new `// use prisma-8` header, and every committed contract is re-emitted so contract.json carries the rc.10 `nullable` flag on to-one relations and contract.d.ts exports the new `Models` namespace; the migration snapshot copies of contract.d.ts are synced to match. Storage hashes are unchanged, so no migration is affected. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
✅ Gizmo reviewed 10280c9 — posted 0 inline comment(s) this pass. Open findings: none Change walkthroughThis PR moves every Dependency pins. All seven touched Schema headers. Every Re-emitted contracts. The rc.10 emitter's output changes show up three ways, applied consistently across all committed contracts:
The gadget/widget test fixtures show the fullest re-emission diff: aggregate types split ( Incidental catch-up. Re-emitting examples/auth also bumps its auth extension reference from |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Comment |
commit: |
There was a problem hiding this comment.
New findings: 🟡 1 minor · trace
Findings outside the diff
- 🟡 Minor · consistency packages/1-prisma-cloud/2-shared-modules/auth/src/tests/fixtures/empty-app/emitted/contract.d.ts — empty-app fixture's emitted contract.d.ts was not re-emitted and still bears the old 'prisma-next contract emit' header
The PR description states every committed contract was re-emitted with the rc.10 toolchain, and indeed the gadget/widget fixtureemitted/contract.d.tsandemitted/contract.jsonfiles were regenerated (generator stamp renamed fromprisma-next contract emittoprisma contract emit). However,packages/1-prisma-cloud/2-shared-modules/auth/src/__tests__/fixtures/empty-app/emitted/contract.d.ts(lines 2-3) — a tracked file, referenced by pack-conformance.integration.test.ts — still carries the oldprisma-next contract emitgenerator header, even though this PR migrated the fixture's ownsource/contract.prismato the new// use prisma-8header. The emitted fixture is now stamped by a toolchain version the PR is moving away from, inconsistent with the other fixtures and with the PR's re-emit claim.
Recommended fix: Re-runprisma contract emitfor the empty-app fixture (or apply the same rc.10 header/message rename used in the gadget/widget fixtures) so all committed emitted contracts carry the rc.10 generator stamp.
Moves every
@prisma/orm-*pin from8.0.0-rc.8to8.0.0-rc.10(rc.9 was skipped). Precedes the v0.19.0 release PR.// use prisma-8header (the old one still works but is deprecated in rc.10).contract.jsongains thenullableflag on to-one relations,contract.d.tsgains theModelsnamespace. Themigrations/snapshots/<hash>/contract.d.tscopies are synced, as the contract-snapshot lint requires. Storage hashes are unchanged, so no migration or snapshot content changed.🤖 Generated with Claude Code