chore(deps-dev)(deps-dev): Bump markdown-it from 14.3.0 to 15.0.0 - #277
chore(deps-dev)(deps-dev): Bump markdown-it from 14.3.0 to 15.0.0#277dependabot[bot] wants to merge 1 commit into
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
commit: |
89b5912 to
ca20970
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ca20970 to
a5ad7e6
Compare
|
✅ Gizmo reviewed 5f1f1e4 — posted 1 inline comment(s) this pass. Open findings: 🟡 2 minor Change walkthroughThis PR is a routine dev-dependency maintenance bump: it raises Fit with the codebase. Consequences for rendered output. Two v15 fixes are visible to the site's build: CommonMark 6.3 conformance for literal backslashes before terminating spaces in link destinations, and lowercase HTML block declarations. Since guides are rendered with |
| "@types/bun": "^1.3.13", | ||
| "@types/markdown-it": "^14.1.2", | ||
| "markdown-it": "^14.1.0", | ||
| "markdown-it": "^15.0.0", |
There was a problem hiding this comment.
🟡 Minor · consistency — Stale @types/markdown-it@14 left installed alongside markdown-it 15, which now bundles its own types
markdown-it 15.0.0 ships its own bundled TypeScript declarations and the upstream changelog explicitly instructs: "Remove @types/markdown-it if you used it." The bump on line 28 leaves the v14 typings (website/package.json line 27, resolved as @types/markdown-it: 14.1.2 in pnpm-lock.yaml) installed alongside markdown-it 15.0.0. The stale @types package describes the markdown-it 14 API (e.g. validateLink/normalizeLink as properties, which are prototype methods in 15), so it is dead weight under moduleResolution: bundler and a version-skew trap if any tooling resolves types through it. The repo's own tsc --noEmit typecheck runs against the bundled v15 types, so leaving this entry can only mask API drift, not catch it.
Recommended fix
Remove the "@types/markdown-it": "^14.1.2" entry from devDependencies in website/package.json (line 27) and rerun pnpm install to drop it from the lockfile, per the markdown-it 15 migration note.
Bumps [markdown-it](https://github.com/markdown-it/markdown-it) from 14.3.0 to 15.0.0. - [Changelog](https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md) - [Commits](markdown-it/markdown-it@14.3.0...15.0.0) --- updated-dependencies: - dependency-name: markdown-it dependency-version: 15.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
a5ad7e6 to
5f1f1e4
Compare
There was a problem hiding this comment.
New findings: 🟡 1 minor · trace
Still open from previous reviews: 🟡 1 minor
| "@types/bun": "^1.3.13", | ||
| "@types/markdown-it": "^14.1.2", | ||
| "markdown-it": "^14.1.0", | ||
| "markdown-it": "^15.0.0", |
There was a problem hiding this comment.
🟡 Minor · correctness — Bump left stale @types/markdown-it@^14.1.2 behind, which markdown-it 15 supersedes with bundled types
markdown-it 15.0.0 ships its own TypeScript declarations, and the upstream changelog explicitly instructs: "Remove @types/markdown-it if you used it." The PR bumps website/package.json:28 to ^15.0.0 but keeps @types/markdown-it@^14.1.2 in devDependencies on line 27. The v14 hand-written declarations now describe an API that no longer matches the installed runtime (e.g. validateLink/normalizeLink moved from properties to prototype methods in v15). TypeScript currently resolves the real package's bundled types first, so this is mostly dead weight today, but the stale stub is a silent drift hazard for anything that consults @types directly and contradicts the documented migration step for the major bump.
Recommended fix
Remove the "@types/markdown-it": "^14.1.2", line from devDependencies (line 27) and run pnpm install so the lockfile drops the stale @types/markdown-it@14 snapshot.
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
Bumps markdown-it from 14.3.0 to 15.0.0.
Changelog
Sourced from markdown-it's changelog.
Commits
157b33b15..0.0 releasedf73cb76doc: rename files3bc8e2dAdd TS types2620dceUpdate contribution guidelines and issue templates7d365fedoc: migration info5c9b7ceUpdate changelog5a996d5doc: fix@exampletags displayf5083f4doc: continue restructuring & theme fixing54289c4Show inlinecodecontent in imagealttag #1142974e2d7text_joinrule fix: process imagealtcontent too (fixes lost escapes and...