Repository navigation
Conversation
ADR 017 said it supersedes ADR 009 and linked to ./adr-009-interaction-tests.md, which does not exist. ADR 009 is behavior-isolation; the ADR it actually supersedes is ADR 008 (adr-008-interaction-tests.md), which already points back at ADR 017. Correct the number and link, and the matching "In ADR 009" reference later in the same document. Also fix: - supercedes/superceded -> supersedes/superseded (ADR 017, ADR 008) - "tha twill" -> "that will" (ADR 018) - "Is is then" -> "It is then" (ADR 011) - doubled "a a" and "an an" (ADR 004, ADR 020) - "everytime" -> "every time" (CONTRIBUTING.md)
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a broken cross-reference in ADR 017 and a handful of typos in the contributor docs.
ADR 017 says it supersedes
ADR 009and links to./adr-009-interaction-tests.md, which doesn't exist. ADR 009 isadr-009-behavior-isolation.md; the ADR that 017 actually revisits is ADR 008 (adr-008-interaction-tests.md, the Storybook play-functions one), which already says it is superseded by ADR 017. This updates the number and link, plus the "InADR 009, we proposed using Storybook'splayfunctions" line further down.Changelog
New
None.
Changed
adrs/adr-017-interaction-tests-revisited.md:ADR 009->ADR 008(link and in-text reference),supercedes->supersedesadrs/adr-008-interaction-tests.md:superceded->supersededadrs/adr-018-responsive-values.md:tha twill->that willadrs/adr-011-snapshot-tests.md:Is is then->It is thenadrs/adr-004-children-as-api.md,adrs/adr-020-live-regions.md: doubleda a/an anCONTRIBUTING.md:everytime->every timeRemoved
None.
Rollout strategy
contributor-docs/, nothing is published, so no changeset.Testing & Reviewing
Docs only. The new ADR 017 link resolves to
contributor-docs/adrs/adr-008-interaction-tests.md.