perf(hooks): stabilize Escape and outside-click callbacks

[joshblack]

Follow up to #8558.

This PR updates useOnEscapePress and useOnOutsideClick to use our existing effect-synchronized callback helper. Callback changes no longer re-register their event handlers or reattach the document listener.

The public APIs stay the same, including explicit callback dependencies passed to useOnEscapePress. This is preparation for its compiler migration; useOnEscapePress remains excluded while we preserve that dependency-array contract.

Changelog

New

Changed

• Update Escape and outside-click handlers to keep event subscriptions stable when callbacks change.
• Update Escape handler IDs to use lazy state initialization, matching outside-click handlers.

Removed

Rollout strategy

This is a patch performance improvement with no public API changes.

• No changes needed in github/github-ui
• Needs changes in github/github-ui
• Ships with feature flag(s)
• Not sure
• None

[changeset-bot]

🦋 Changeset detected

Latest commit: 01ac8b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

[primer-integration]

Integration test results from github/github-ui PR:

  Changes Waiting
  CI Passed
  VRT Waiting
  Projects Running