Skip to content

perf(react-compiler): enable useSafeTimeout - #8553

Closed
joshblack wants to merge 1 commit into
mainfrom
joshblack/react-compiler-safe-timeout
Closed

joshblack wants to merge 1 commit into
mainfrom
joshblack/react-compiler-safe-timeout

Conversation

@joshblack

@joshblack joshblack commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Closes #

Enable React Compiler for useSafeTimeout as the first entry in our low-risk migration stack. Our migration report identifies the cleanup's ref access as the blocker.

Changelog

New

Changed

  • Capture the timer Set when the effect runs so cleanup does not read through the ref. The Set stays shared with both timer callbacks, including timers registered after the effect.
  • Remove the compiler exclusion and add a minor changeset, matching our recent compiler rollout.

Removed

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
@changeset-bot

changeset-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6d6cbe0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the staff Author is a staff member label Oct 15, 2026
@joshblack
joshblack added this pull request to stack #8556 October 15, 2026 20:50
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@joshblack

Copy link
Copy Markdown
Member Author

Combined into #8555 so we can review these small compiler migrations in one PR.

This branch was successfully deployed

1 active and 1 inactive deployments
storybook-preview-8553 — 6d6cbe0b Deployed Oct 15, 2026 by github-actions[bot]
github-pages — 6d6cbe0b Deployed Oct 15, 2026 by joshblack via deploy-preview #33720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant