Repository navigation
fix: use normal input background for SelectPanel filter text input - #8545
Open
tay1orjones wants to merge 4 commits into
Open
tay1orjones wants to merge 4 commits into
tay1orjones wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 28c4fc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tay1orjones
added
the
update snapshots
github-actions
Bot
added
the
integration-tests: recommended
Contributor
|
tay1orjones
added
update snapshots
github-actions
Bot
removed
the
update snapshots
tay1orjones
added this pull request to stack #8546
October 14, 2026 18:12
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dcc70c7e-b01a-4abf-b3c3-f5251562a733
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 198155a9-4a01-40bd-a329-f414c1c8cb50
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 198155a9-4a01-40bd-a329-f414c1c8cb50
tay1orjones
force-pushed
the
tay1orjones-select-panel-legacy-contrast
branch
from
October 14, 2026 18:53
0f71353 to
28c4fc9
Compare
tay1orjones
changed the title
tay1orjones
marked this pull request as ready for review
October 14, 2026 19:09
tay1orjones
requested review from
TylerJDev
and
a balanced review from Copilot
October 14, 2026 19:09
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped change consistently preserves explicit overrides and has matching documentation and regression coverage; runtime tests were not executed.
0 open findings
What changed in this PR
Updates SelectPanel to use the normal TextInput background, following the deprecation of contrast.
Changes:
- Adds a default-off flag to restore legacy contrast styling while preserving explicit prop overrides.
- Adds regression tests and a legacy-contrast story.
- Documents the behavior and includes a patch changeset.
| File | Description |
|---|---|
| packages/react/src/SelectPanel/SelectPanel.tsx | Uses flag-controlled contrast defaults. |
| packages/react/src/SelectPanel/SelectPanel.test.tsx | Tests defaults, overrides, filtering, and focus. |
| packages/react/src/SelectPanel/SelectPanel.features.stories.tsx | Adds a legacy-contrast demonstration. |
| packages/react/src/SelectPanel/SelectPanel.docs.json | Documents defaults and override precedence. |
| packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Registers the default-off compatibility flag. |
| e2e/components/SelectPanel.test.ts | Checks themes, panel variants, accessibility, and screenshots. |
| .changeset/select-panel-default-background.md | Records the patch release change. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
github-actions
Bot
added
integration-tests: failing
Contributor
Author
Base automatically changed from
tay1orjones-contrast-prop-deprecation
to
main
October 15, 2026 15:25
|
Integration test results from github/github-ui PR:
All checks passed! |
github-actions
Bot
added
integration-tests: passing
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8525.
SelectPanel's forced contrast background can make its filter input look disabled. Use the normal TextInput background by default, with a flag to restore the previous appearance.
Changelog
New
Changed
Removed
Rollout strategy
primer_react_select_panel_legacy_contrastdefaults tofalse, so the background changes without enabling a flag. Enable it to restore the previous background. ExplicittextInputProps.contraststill wins:trueenables contrast;falseor explicitly passingundefineddisables it. The prop remains deprecated.Testing & Reviewing
Open SelectPanel's Default story and compare it with Features / Legacy Contrast. Switch between light, dark, and high-contrast themes. The default input should use the normal background; the legacy story should restore the inset background. Type
bugin the filter, then press Escape: filtering should work and focus should return to the anchor. Repeat with the modal story and a narrow viewport.