Skip to content

Fix/sidebar padding prop #8535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naveedsajjdawan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/sidebar padding prop #8535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
515ea3c
fix: apply padding prop to PageLayout sidebar
naveedsajjdawan Oct 14, 2026
d69ea15
test: cover PageLayout sidebar padding
naveedsajjdawan Oct 14, 2026
2df60db
docs: add changeset for sidebar padding fix
naveedsajjdawan Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-sidebar-padding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Fix `PageLayout.Sidebar` so its `padding` prop applies independently of the root layout padding.
2 changes: 2 additions & 0 deletions packages/react/src/PageLayout/PageLayout.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,8 @@
.Sidebar {
width: var(--pane-width-size);
height: 100%;
/* stylelint-disable-next-line primer/spacing */
padding: var(--spacing);
overflow: auto;

&:where([data-resizable]) {
Expand Down
18 changes: 18 additions & 0 deletions packages/react/src/PageLayout/PageLayout.sidebar-padding.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import {describe, it, expect} from 'vitest'
import {render} from '@testing-library/react'
import {PageLayout} from './PageLayout'

describe('PageLayout.Sidebar padding', () => {
it('applies sidebar padding when the root has no padding', () => {
const {container} = render(
<PageLayout padding="none">
<PageLayout.Content>Content</PageLayout.Content>
<PageLayout.Sidebar padding="condensed">Sidebar</PageLayout.Sidebar>
</PageLayout>,
)

const sidebar = container.querySelector<HTMLElement>('[data-component="PageLayout.Sidebar"]')
expect(sidebar).not.toBeNull()
expect(getComputedStyle(sidebar!).paddingTop).toBe('16px')
})
})
Loading