Skip to content

Fix duplicate FormControl inputs in horizontal layout - #8529

Open
orpheusdark wants to merge 1 commit into
primer:mainfrom
orpheusdark:formcontrol-horizontal-input-dup
Open

orpheusdark wants to merge 1 commit into
primer:mainfrom
orpheusdark:formcontrol-horizontal-input-dup

Conversation

@orpheusdark

Copy link
Copy Markdown

Closes #8487

Horizontal FormControl rendered a cloned input alongside the original for non-choice inputs. The horizontal layout now excludes the original input, and a regression test checks that only one textbox is rendered.

Changelog

New

  • None.

Changed

  • Fixed duplicate non-choice inputs in horizontal FormControl layouts.

Removed

  • None.

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure — open source contributor; no rollout plan identified.
  • None

Testing & Reviewing

  • FormControl tests passed: 40 tests.
  • ESLint and Prettier checks passed for the changed files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 13, 2026 07:32
@orpheusdark
orpheusdark requested a review from a team as a code owner October 13, 2026 07:32
@orpheusdark
orpheusdark requested a review from jonrohan October 13, 2026 07:32
@changeset-bot

changeset-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bc1fe81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@orpheusdark
orpheusdark requested a balanced review from Copilot October 13, 2026 07:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch was successfully deployed

1 active deployment
github-pages — bc1fe814 Deployed Oct 13, 2026 by orpheusdark via deploy-preview #29923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FormControl renders duplicate non-choice inputs when layout="horizontal"

2 participants