Skip to content

perf(react-compiler): enable ActionBar, Overlay, TextInput, and TooltipV2 - #8512

Merged
joshblack merged 1 commit into
refactor/react-compiler-low-risk-batch-2from
refactor/react-compiler-low-risk-batch-3
Oct 15, 2026
Merged

joshblack merged 1 commit into
refactor/react-compiler-low-risk-batch-2from
refactor/react-compiler-low-risk-batch-3

Conversation

@joshblack

Copy link
Copy Markdown
Member

No linked issue.

Enable React Compiler optimization for ActionBar, FilteredActionList announcements, Overlay, TextInput, and TooltipV2. These sources already pass our compiler checker, so component implementations and APIs stay unchanged.

Changelog

New

None.

Changed

  • Enable automatic memoization for the five compiler-clean sources.
  • Add a minor changeset for the rendering optimization.

Removed

None.

Rollout strategy

Selected minor so we can coordinate adoption of the rendering optimization. No consumer API changes are needed.

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Testing & Reviewing

Normal-mode Oxc compilation and packaged memo-cache output were verified for all five sources. Full build, type checking, unit tests, node Storybook checks, lint, and CSS lint passed before the final rebase. Compiler lint, combined focused tests (including Autocomplete and deprecated slots), and formatting passed afterward.

Interaction smoke checks passed in an isolated Storybook instance. Review ActionBar navigation and overflow, filter announcements, Overlay focus and dismissal, TextInput input handling, and Tooltip hover and Escape dismissal.

@changeset-bot

changeset-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 45de9f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack
joshblack added this pull request to stack #8506 October 6, 2026 18:41
@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 6, 2026 18:51 Inactive
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-3 branch from ab13b3d to 0009c33 Compare October 6, 2026 20:43
@github-actions
github-actions Bot requested a deployment to storybook-preview-8512 October 6, 2026 20:48 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 6, 2026 20:57 Inactive
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-3 branch from 0009c33 to cc033b3 Compare October 6, 2026 20:58
@github-actions
github-actions Bot requested a deployment to storybook-preview-8512 October 6, 2026 21:02 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 6, 2026 21:14 Inactive
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-3 branch 2 times, most recently from 61b0690 to 848acf6 Compare October 7, 2026 20:26
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 7, 2026 20:35 Inactive
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-3 branch from 848acf6 to 51ca2b0 Compare October 12, 2026 16:15
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 12, 2026 16:25 Inactive
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-3 branch 2 times, most recently from 618d9be to 7e6aad2 Compare October 14, 2026 16:10
@joshblack
joshblack marked this pull request as ready for review October 14, 2026 16:11
@joshblack
joshblack requested a review from a team as a code owner October 14, 2026 16:11
@joshblack
joshblack requested review from TylerJDev and a balanced review from Copilot October 14, 2026 16:11
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 14, 2026 16:15 Inactive
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-3 branch from 7e6aad2 to 8b6df68 Compare October 14, 2026 16:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Generated memoization behavior across interaction-heavy components needs human verification despite the reported passing checks.

0 open findings

What changed in this PR

Enables React Compiler memoization for five Primer React sources without changing component implementations or public APIs.

Changes:

  • Removes compiler exclusions for ActionBar, FilteredActionList announcements, Overlay, TextInput, and TooltipV2.
  • Adds a minor changeset for the rendering optimization.
File Description
packages/​react/​script/​react-compiler.mjs Enables compilation for five previously excluded sources.
.changeset/​react-compiler-low-risk-batch-3.md Records the rendering optimization as a minor release.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions
github-actions Bot requested a deployment to storybook-preview-8512 October 14, 2026 16:22 Abandoned
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-3 branch from 8b6df68 to 45de9f2 Compare October 14, 2026 16:31
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 14, 2026 16:38 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 14, 2026 16:50 Inactive
@github-actions github-actions Bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 15, 2026
@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  Changes   Passed
Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@github-actions github-actions Bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 15, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cf031929-064e-4482-961d-25594325eb1b
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-3 branch from 45de9f2 to 5a1395c Compare October 15, 2026 16:32
@joshblack joshblack added the integration-tests: skipped manually Changes in this PR do not require an integration test label Oct 15, 2026
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8512 October 15, 2026 16:44 Inactive
@joshblack
joshblack added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit e236683 Oct 15, 2026
61 checks passed
@joshblack
joshblack deleted the refactor/react-compiler-low-risk-batch-3 branch October 15, 2026 17:01
@primer primer Bot mentioned this pull request Oct 15, 2026

This branch was successfully deployed

1 active and 1 inactive deployments
storybook-preview-8512 — 5a1395c2 Deployed Oct 15, 2026 by github-actions[bot]
github-pages — 5a1395c2 Deployed Oct 15, 2026 by joshblack via deploy-preview #33714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants