Repository navigation
perf(react-compiler): enable ActionBar, Overlay, TextInput, and TooltipV2 - #8512
Conversation
🦋 Changeset detectedLatest commit: 45de9f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
ab13b3d to
0009c33
Compare
0009c33 to
cc033b3
Compare
61b0690 to
848acf6
Compare
848acf6 to
51ca2b0
Compare
618d9be to
7e6aad2
Compare
7e6aad2 to
8b6df68
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Generated memoization behavior across interaction-heavy components needs human verification despite the reported passing checks.
0 open findings
What changed in this PR
Enables React Compiler memoization for five Primer React sources without changing component implementations or public APIs.
Changes:
- Removes compiler exclusions for ActionBar, FilteredActionList announcements, Overlay, TextInput, and TooltipV2.
- Adds a minor changeset for the rendering optimization.
| File | Description |
|---|---|
| packages/react/script/react-compiler.mjs | Enables compilation for five previously excluded sources. |
| .changeset/react-compiler-low-risk-batch-3.md | Records the rendering optimization as a minor release. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
8b6df68 to
45de9f2
Compare
|
Integration test results from github/github-ui PR:
All checks passed! |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cf031929-064e-4482-961d-25594325eb1b
45de9f2 to
5a1395c
Compare
|
No linked issue.
Enable React Compiler optimization for ActionBar, FilteredActionList announcements, Overlay, TextInput, and TooltipV2. These sources already pass our compiler checker, so component implementations and APIs stay unchanged.
Changelog
New
None.
Changed
Removed
None.
Rollout strategy
Selected
minorso we can coordinate adoption of the rendering optimization. No consumer API changes are needed.Testing & Reviewing
Normal-mode Oxc compilation and packaged memo-cache output were verified for all five sources. Full build, type checking, unit tests, node Storybook checks, lint, and CSS lint passed before the final rebase. Compiler lint, combined focused tests (including Autocomplete and deprecated slots), and formatting passed afterward.
Interaction smoke checks passed in an isolated Storybook instance. Review ActionBar navigation and overflow, filter announcements, Overlay focus and dismissal, TextInput input handling, and Tooltip hover and Escape dismissal.