Skip to content

perf(react-compiler): enable Checkbox, Tooltip, and useForceUpdate - #8511

Merged
joshblack merged 1 commit into
refactor/react-compiler-low-risk-batch-1from
refactor/react-compiler-low-risk-batch-2
Oct 15, 2026
Merged

joshblack merged 1 commit into
refactor/react-compiler-low-risk-batch-1from
refactor/react-compiler-low-risk-batch-2

Conversation

@joshblack

Copy link
Copy Markdown
Member

No issue to close.

Enable React Compiler for Checkbox, the legacy Tooltip, and useForceUpdate. These files already compile without source refactors or public API changes.

Changelog

New

None.

Changed

  • Enable compiler output for Checkbox, Tooltip, and useForceUpdate.
  • Enable compilation of the Autocomplete test fixtures.
  • Add a minor changeset for the component optimizations.

Removed

Remove the corresponding compiler exclusions. No public APIs are removed.

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Minor release for coordinated compiler optimizations, with no intended visual or accessibility changes.

Testing & Reviewing

Compiler checks, the full test suite, build, type checking, lint, and formatting pass. Checkbox and legacy Tooltip stories render successfully in Chromium.

Review Checkbox's controlled, uncontrolled, and indeterminate states, ref forwarding with both existing feature-flag settings, and Tooltip's accessible labels.

ActionMenu and SelectPanel test files remain excluded: enabling their compilation exposed anchor replacement and initial empty-state behavior that needs separate work.

Dedicated VRT/AVT and github-ui integration were not run.

@joshblack
joshblack added this pull request to stack #8506 October 6, 2026 18:35
@changeset-bot

changeset-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 45bb6ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  Changes   Passed
Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-2 branch from a636f8e to 62392d2 Compare October 6, 2026 20:43
@github-actions
github-actions Bot requested a deployment to storybook-preview-8511 October 6, 2026 20:47 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8511 October 6, 2026 20:58 Inactive
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-2 branch from 62392d2 to 9953239 Compare October 6, 2026 20:58
@github-actions
github-actions Bot requested a deployment to storybook-preview-8511 October 6, 2026 21:02 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8511 October 6, 2026 21:12 Inactive
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-2 branch from 9953239 to 7929a9d Compare October 7, 2026 16:43
@github-actions github-actions Bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-2 branch from 7929a9d to 8fe5d18 Compare October 7, 2026 20:26
@github-actions github-actions Bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@joshblack
joshblack requested review from liuliu-dev and a balanced review from Copilot October 14, 2026 16:11
@github-actions github-actions Bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 14, 2026
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8511 October 14, 2026 16:15 Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped exclusions update has no identified blocking issues, and reported validation covers the affected behavior.

0 open findings

What changed in this PR

Extends React Compiler adoption in @primer/react without source refactors or public API changes.

Changes:

  • Removes compiler exclusions for Checkbox, legacy Tooltip, useForceUpdate, and Autocomplete test fixtures.
  • Adds a minor changeset describing component rendering optimizations.
File Description
packages/​react/​script/​react-compiler.mjs Enables compilation for four previously excluded files.
.changeset/​react-compiler-low-risk-batch-2.md Records the component optimizations for release.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-2 branch from 6e1d8a3 to 1428f99 Compare October 14, 2026 16:17
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
github-actions Bot requested a deployment to storybook-preview-8511 October 14, 2026 16:21 Abandoned
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-2 branch from 1428f99 to 45bb6ac Compare October 14, 2026 16:31
@github-actions github-actions Bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: cf031929-064e-4482-961d-25594325eb1b
@joshblack
joshblack force-pushed the refactor/react-compiler-low-risk-batch-2 branch from 45bb6ac to 1f834ae Compare October 15, 2026 16:32
@joshblack joshblack added the integration-tests: skipped manually Changes in this PR do not require an integration test label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8511 October 15, 2026 16:47 Inactive
@joshblack
joshblack added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 6d14fa0 Oct 15, 2026
60 of 61 checks passed
@joshblack
joshblack deleted the refactor/react-compiler-low-risk-batch-2 branch October 15, 2026 17:01
@primer primer Bot mentioned this pull request Oct 15, 2026

This branch was successfully deployed

1 active and 1 inactive deployments
storybook-preview-8511 — 1f834ae2 Deployed Oct 15, 2026 by github-actions[bot]
github-pages — 1f834ae2 Deployed Oct 15, 2026 by joshblack via deploy-preview #33713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants