Repository navigation
Remove support for sx from SubNav components - #6694
Conversation
|
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
SubNav, Text, Textarea, TextInput, TextInputWithTokens componentsSubNav, Textarea, TextInput, TextInputWithTokens components
…d breaking changes in components that depend on Text
size-limit report 📦
|
…vert changes in TextInput for next PR
…-text-and-other-components
SubNav, Textarea, TextInput, TextInputWithTokens componentsSubNav and Textarea components
SubNav and Textarea componentsSubNav, TextInputWithTokens and Textarea components
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2539 |
|
🟢 ci completed with status |
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated sx prop support from SubNav and Textarea components as part of ongoing cleanup efforts to eliminate the sx prop from Primer React components. The changes are focused on documentation and Storybook configuration updates rather than functional code changes.
Key changes:
- Remove
sxprop documentation from component docs.json files - Remove
sxfrom Storybook argTypes configuration - Add changeset for patch release
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/react/src/Textarea/Textarea.stories.tsx |
Remove sx from Storybook argTypes configuration |
packages/react/src/Textarea/Textarea.docs.json |
Remove deprecated sx prop from component documentation |
packages/react/src/SubNav/SubNav.docs.json |
Remove deprecated sx prop from SubNav, SubNav.Link, and SubNav.Links documentation |
.changeset/quick-guests-ask.md |
Add changeset documenting the removal of sx support |
joshblack
left a comment
There was a problem hiding this comment.
LGTM! Just left a comment around the changeset
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@primer/react': patch | |||
There was a problem hiding this comment.
Since these are just docs/stories changes I think you're okay to not include a changeset if that helps 👀
Remove
sxin stories and docs for theSubNavandTextareacomponent.Closes #5817
sxusage , tracking here: https://github.com/github/primer/issues/5827