Repository navigation
fix(storybook): preserve legacy data visualization story links - #1422
liuliu-dev wants to merge 1 commit into
Conversation
Restore the published Highcharts accent and muted story IDs as hidden aliases of the current DataVis stories. Cover legacy and current URLs in light and dark themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
There was a problem hiding this comment.
🟢 Approval recommended
The aliases reuse existing rendering behavior, focused regression coverage is included, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Restores legacy DataVis Storybook links after the story restructuring while preserving current stories and sidebar entries.
Changes:
- Adds legacy Highcharts accent and muted aliases that reuse the current renderers.
- Excludes aliases from the sidebar and automatic test discovery.
- Adds eight Playwright cases covering legacy/current links, light/dark themes, populated tables, and nontransparent swatches.
| File | Description |
|---|---|
e2e/storybook.test.ts |
Adds explicit regression coverage for legacy and current DataVis links. |
docs/storybook/stories/Color/Display/DataVisColors.stories.tsx |
Adds backward-compatible story aliases without duplicate sidebar entries. |
Review effort: Balanced
|
fix in primer-docs instead https://github.com/github/primer-docs/pull/1395 |
Summary
The published
color-datavis--highcharts-accent-colorsURL fails withNoStoryMatchErrorbecause the legacy stories were replaced with renamed DataVis stories. Restore backward-compatible accent and muted story IDs while preserving the current stories and sidebar.List of notable changes:
!dev/!testtags.What should reviewers focus on?
Steps to test:
?path=/story/color-datavis--highcharts-accent-colors&globals=theme%3Alightand verify the accent token table renders.color-datavis--highcharts-muted-colors, then verify both currentdata-vis-*URLs still work in light and dark themes.Validation performed:
npm run lint && npm run format && npm run test && npm run build— passed, including 536 unit tests and 9 integration tests; rerun successfully on this isolated PR branch.STORYBOOK_URL=http://localhost:6008 npx playwright test e2e/storybook.test.ts --grep 'data visualization story links' --workers=2— passed, 8/8 cases.Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist: