Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new CSS layer to encapsulate octicon styles and ensure they take precedence over downstream Primer React styles.
- Wraps the
.octiconclass in a@layer primer.iconsblock. - Guarantees the
primer.iconslayer is first to avoid unintended overrides.
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
When styles downstream in Primer React interact with an icon, and
.octiconis present on the page, the.octiconcall will take precedence since it is in the anonymous layer and Primer React styles are brought in through theprimer-reactlayer.This change updates the
.octiconclass to be wrapped in a@layernamedprimer.icons. We should make sure this layer appears first to avoid any overrides in the future.