[REVIEW] 동근님 리뷰를 위한 PR #56
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| REACT_APP_TITLE=Time_Divider | ||
| REACT_APP_DESCRIPTION=당신은 시간을 잘 나누어 사용하고 있나요? 당신의 사용가능한 시간을 분배하세요! | ||
| REACT_APP_API_URL='' | ||
| REACT_APP_PORT='' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| REACT_APP_TITLE=Time_Divider | ||
| REACT_APP_DESCRIPTION=당신은 시간을 잘 나누어 사용하고 있나요? 당신의 사용가능한 시간을 분배하세요! | ||
| REACT_APP_API_URL='' | ||
| REACT_APP_PORT='' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,22 @@ | ||
| import GlobalStyle from '../src/styles/GlobalStyle' | ||
|
|
||
| export const parameters = { | ||
| actions: { argTypesRegex: '^on[A-Z].*' }, | ||
| controls: { | ||
| matchers: { | ||
| color: /(background|color)$/i, | ||
| date: /Date$/, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| export const decorators = [ | ||
| Story => { | ||
| return ( | ||
| <> | ||
| <GlobalStyle /> | ||
| <Story /> | ||
| </> | ||
| ) | ||
| }, | ||
| ] | ||
|
Comment on lines
3
to
+22
There was a problem hiding this comment. P5; 요 부분은 간격이 tab 4로 잡혀있는 것 같아요. 느낌상 프리티어에 vscode가 연결이 잘 안되어있거나 vscode 익스텐션과 꼬인 것이 있어보여요!!
Member
Author
There was a problem hiding this comment. 앗 서로 리뷰를 거의 하지 못하고 작업했더니 저희 자체적으로 잡아내지 못한 문제네요 ㅜㅜ!
Member
There was a problem hiding this comment. 가끔씩 탭이 많이 들어가는 파일들이 생기는 현상이 있긴 했는데 이번 기회에 확인해서 수정해봐야겠네요
Member
Author
There was a problem hiding this comment.
eol도 가끔 들어가더라구요..! 😢 |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,48 @@ | ||
| # 시간 분배기(Timer Divider) | ||
|
|
||
| ### 팀원 | ||
|
There was a problem hiding this comment. P5; README도 중요한 내용부터 위에 배치하는 것을 저는 개인적으로 선호하고 있어요. |
||
|
|
||
| <table> | ||
| <tr> | ||
| <td align="center"> | ||
| <img src="https://avatars.githubusercontent.com/u/64780560?v=4" width="100px;" alt="신다혜"/> | ||
| </td> | ||
| <td align="center"> | ||
| <img src="https://avatars.githubusercontent.com/u/54318460?v=4" width="100px;" alt="김경현"/> | ||
| </td> | ||
| <td align="center"> | ||
| <img src="https://avatars.githubusercontent.com/u/81891292?v=4" width="100px;" alt="이지원"/> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td align="center"> | ||
| <a href="https://github.com/dahye1013"> | ||
| <div>신다혜</div> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/codeisneverodd"> | ||
| <div>김경현</div> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/ljw0096"> | ||
| <div>이지원</div> | ||
| </a> | ||
| </td> | ||
| </tr> | ||
| </table> | ||
|
|
||
| --- | ||
|
|
||
| ## 프로젝트 관리 문서 | ||
|
|
||
| [기획서 노션 링크](https://rust-damselfly-7e5.notion.site/51954418603645efb4a2c53220321e02) | ||
|
|
||
| [프로젝트 진행 칸반](https://github.com/prgrms-fe-devcourse/FEDC2_TimeDivider_Root/projects) | ||
|
|
||
| [논의 사항 정리](https://github.com/prgrms-fe-devcourse/FEDC2_TimeDivider_Root/discussions) | ||
|
|
||
| [피그마 시안 - 프로토타입 및 설계](https://www.figma.com/file/55rLirP3Lt9mifvgfOLi6n/Time?node-id=0%3A1) | ||
|
|
||
| [피그마 시안 - 디자인 수정](https://www.figma.com/file/55rLirP3Lt9mifvgfOLi6n/Time?node-id=356%3A653) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "baseUrl": "./src" | ||
| }, | ||
| "include": ["src"] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ASK!
요 Description을 따로 env 값으로 관리하시는 이유가 있을까요??
별도의 상수 파일을 만들어 관리해도 좋을 것 같아서요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json에서 script로 돌릴때 돌아가는 환경변수를 다르게 설정해두었는데요!
env.local,env.developmenet,env.production개발중인 화면을 개발자가 볼때는 브라우저 title에
Time_Divider빌드 배포된 것은
시간분배하기이런식으로 볼 수 있게 하려는 의도였어요!하지만, 의도에 대한 실익은 보지 못해서 상수로 바꿔도 될 것 같아요. 좀 더 고민해보도록 수정해두겠습니다~~