Skip to content

chore(CI): add tests for ESLint 8#428

Merged
BPScott merged 1 commit into
prettier:masterfrom
MichaelDeBoey:eslint-8
Nov 5, 2021
Merged

chore(CI): add tests for ESLint 8#428
BPScott merged 1 commit into
prettier:masterfrom
MichaelDeBoey:eslint-8

Conversation

@MichaelDeBoey

@MichaelDeBoey MichaelDeBoey commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

ESLint v8.0.0 is released 🎉

devDependency compatibility with ESLint 8:


I wanted to update eslint-config-prettier, eslint-plugin-eslint-plugin, eslint-plugin-node & vue-eslint-parser to their latest minor, but that would break CI on the older ESLint/Node versions

If wanted, I can do it in this PR or make a second PR with all the breaking changes.
Edit: This can be done without a breaking change after #429 is merged


Closes #427

@BPScott

BPScott commented Aug 30, 2021

Copy link
Copy Markdown
Member

If you rebase, a lot of this goes away. It looks like CI has passed successfully though, so it seems we're all v8 compliant.

I'd prefer to avoid testing pre-release versions though if possible so I'm tempted to close this, and we can revisit once v8.0.0 is released.

@MichaelDeBoey

Copy link
Copy Markdown
Contributor Author

@BPScott Rebased onto master

I've also updated all ESLint-related dependencies to their latest versions.

Comment thread package.json Outdated
Comment thread package.json Outdated
@Belco90

Belco90 commented Nov 15, 2021

Copy link
Copy Markdown

Hey! When will be this new version published? It didn't trigger any new release since it was merged as a chore, but this should be a new minor adding compatibility for ESLint v8.

@BPScott

BPScott commented Nov 15, 2021

Copy link
Copy Markdown
Member

This PR changed development-only dependencies and what we run in CI. There were no code changes required to support eslint 8, what is already published to npm is sufficient.

@martin-badin

Copy link
Copy Markdown

Hi, I think you need to update peerDependencies as well.

 "peerDependencies": {
    "eslint": ">=7.28.0",
    "prettier": ">=2.0.0"
  },

@BPScott

BPScott commented Jan 26, 2022

Copy link
Copy Markdown
Member

>=7.28.0 means anything above version including v8.ANYTHING. This package continues to work with both eslint v7.28 and up and v8 and up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x

5 participants