Skip to content

fix: potential memory leak due to growing string table#511

Merged
marvinhagemeister merged 2 commits into
mainfrom
str-perf
May 6, 2026
Merged

fix: potential memory leak due to growing string table#511
marvinhagemeister merged 2 commits into
mainfrom
str-perf

Conversation

@marvinhagemeister
Copy link
Copy Markdown
Member

Fix potential memory leak due to growing an unbounded string table. Also make encoding faster.

@marvinhagemeister marvinhagemeister merged commit 42681e4 into main May 6, 2026
1 check passed
@marvinhagemeister marvinhagemeister deleted the str-perf branch May 6, 2026 08:22
upupming added a commit to lynx-family/preact-devtools that referenced this pull request May 25, 2026
…t to 0.121.0 (#4)

* fix: broken hooks detection (preactjs#507)

Note that hooks are pretty much supported everywhere so this had no production impact.

* fix: incorrect props string truncation (preactjs#508)

* chore: only fetch required preact versions for tests (preactjs#509)

* chore: harden e2e tests (preactjs#510)

Lots of flakyness was caused by trying to one-shot assertions by grabbing an element and asserting on it instead of polling. Other issues were basically race conditions between elements of which there were plenty.

All of this is now much more reliable thanks to new assertions in playwright.

* fix: potential memory leak due to growing string table (preactjs#511)

The string table was unbounded, so add a LRU cache to limit growth. Also make encoding of strings faster while we're at it.

* fix: custom filter not removed + use popover (preactjs#512)

* chore: move unit tests to vitest (preactjs#513)

* chore: switch to oxlint + oxfmt (preactjs#514)

* chore: remove husky + lint-staged (preactjs#515)

* chore: update dependencies (preactjs#516)

Also fix text signal issue with newer signals versions

* chore: fix inline build failing (preactjs#517)

* chore: update dependencies (preactjs#518)

* fix: make hook inspection attachment more robust (preactjs#519)

Using a `setTimeout` was always a bit meh.

---------

Co-authored-by: Marvin Hagemeister <hello@marvinh.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant