chore: harden e2e tests#510
Merged
Merged
Conversation
Lots of flakyness was caused by trying to one-shot assertions by grabbing an element and asserting on it instead of polling. Other issues were basically race conditions between elements of which there were plenty. All of this is now much more reliable thanks to new assertions in playwright.
JoviDeCroock
approved these changes
May 6, 2026
upupming
added a commit
to lynx-family/preact-devtools
that referenced
this pull request
May 25, 2026
…t to 0.121.0 (#4) * fix: broken hooks detection (preactjs#507) Note that hooks are pretty much supported everywhere so this had no production impact. * fix: incorrect props string truncation (preactjs#508) * chore: only fetch required preact versions for tests (preactjs#509) * chore: harden e2e tests (preactjs#510) Lots of flakyness was caused by trying to one-shot assertions by grabbing an element and asserting on it instead of polling. Other issues were basically race conditions between elements of which there were plenty. All of this is now much more reliable thanks to new assertions in playwright. * fix: potential memory leak due to growing string table (preactjs#511) The string table was unbounded, so add a LRU cache to limit growth. Also make encoding of strings faster while we're at it. * fix: custom filter not removed + use popover (preactjs#512) * chore: move unit tests to vitest (preactjs#513) * chore: switch to oxlint + oxfmt (preactjs#514) * chore: remove husky + lint-staged (preactjs#515) * chore: update dependencies (preactjs#516) Also fix text signal issue with newer signals versions * chore: fix inline build failing (preactjs#517) * chore: update dependencies (preactjs#518) * fix: make hook inspection attachment more robust (preactjs#519) Using a `setTimeout` was always a bit meh. --------- Co-authored-by: Marvin Hagemeister <hello@marvinh.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of flakyness was caused by trying to one-shot assertions by grabbing an element and asserting on it instead of polling. Other issues were basically race conditions between elements of which there were plenty.
All of this is now much more reliable thanks to new assertions in playwright.