Repository navigation
Conversation
Plain http:// to an injection host got the key injected and sent unencrypted (reproduced live with a fake key). Now it goes out without the credential, as if none were configured, with a warning. Idea credit: Agent Substrate's egress credential injection, which skips cleartext likewise.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
A plain
http://request to an injection host got the real key injected and sent unencrypted. The injector matched on host only, never on scheme.Anyone on the network path between the proxy and the provider could read it. Any authenticated caller could trigger it, including a prompt-injected Prax asked to fetch
http://api.openai.com/....The fix
Idea credit: Agent Substrate (Google, CNCF sandbox application cncf/sandbox#523). Its egress credential injection has the same rule: a secret is never put on a cleartext wire.
Verified
Live, in a throwaway
mitmproxy/mitmproxy:latestcontainer with a fake key and example.com as the injection host:http://example.cominjected header:X-Test-KeyNOT injecting … cleartext httphttps://example.comUnit: 2 tests. The cleartext test fails without the fix. 65 passed, ruff clean.
Independent of #3–#6; small conflicts are possible in
mitm_addon.py, and I'll rebase whichever merges later.