PR-1: Central correctness fixes (stacked on pr-0-guardrails) - #2
Open
prathameshkurunkar7 wants to merge 7 commits into
Open
PR-1: Central correctness fixes (stacked on pr-0-guardrails)#2prathameshkurunkar7 wants to merge 7 commits into
prathameshkurunkar7 wants to merge 7 commits into
Conversation
…created Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
prathameshkurunkar7
force-pushed
the
pr-0-guardrails
branch
from
August 6, 2026 05:58
b1f740e to
4574b73
Compare
prathameshkurunkar7
force-pushed
the
pr-1-correctness
branch
from
August 6, 2026 05:58
9ce01db to
95cecce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctness bug fixes for the Central pre-1.0 refactor.
STACKED on
pr-0-guardrails(base ispr-0-guardrails, notdevelop).Fixes:
DuplicateEntryErrorwhen creating a second custom role./serversterminate — no longer fires over GET on mount; failures now surface as error toasts.central.notification.api.*. The old billing endpoints were deleted by feat(notifications): backend notification layer frappe/central#202, so the screen 404s ondeveloptoday.ServerMap,Sidebar,useServerMapData, andSiteNamePage.useIsMobilenow backed bymatchMediawith scoped disposal.Each fix has a regression test where there's a backend. The two backend fixes (Team Role autoname, Service Backend region) were verified live on
ci-test.localhost.🤖 Generated with Claude Code